Allow environment variables when configuring FPM pools #650
+65
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Allows for PHP FPM pool settings to be configured as environment variables (
pm_max_children => '${PM_MAX_CHILDREN}'
) in addition to their existing typed formats.I debated about the best way to add this, and ended up adding
Variant
types, along with a single custom type. I did this because there were varying types (Integer[0], Integer[1], Php::Duration
) that I didn't want to have to duplicate.The env based configuration applies to every setting, but for right now I've added it to the most common ones where due to the stricter validation, it would previously fail.
This Pull Request (PR) fixes the following issues
Fixes #649