Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper yaml for the mongod config #737

Closed
wants to merge 1 commit into from

Conversation

stevenpost
Copy link
Contributor

It turns out that not properly doing this caused authenthication not being properly disabled on later versions.

It turns out that not properly doing this caused authenthication not
being properly disabled on later versions.
@h-haaks
Copy link
Contributor

h-haaks commented Apr 9, 2024

You have to handle the 'config_data' ( additional config ) some how in the template.
If someone starts to add propper yaml hashes to it it will generate duplicate key in the config file.

Might be possible to generate a complete ruby hash from all the params and then use to_yaml() on that.

@h-haaks h-haaks mentioned this pull request Apr 9, 2024
@stevenpost
Copy link
Contributor Author

You have to handle the 'config_data' ( additional config ) some how in the template. If someone starts to add propper yaml hashes to it it will generate duplicate key in the config file.

Might be possible to generate a complete ruby hash from all the params and then use to_yaml() on that.

Using to_yaml was my first thought, but it proved a bit difficult to properly implement in the mongodb::config class. If you do decide to go down the path of using a hash for config (not totally against it) it would make things easier for us... but also make it way more easy to shoot yourself in the foot. Then again, I think sysadmins using Puppet are expected to know what they are doing...

It would be a major break though.

@stevenpost
Copy link
Contributor Author

Superseeded by #735

@stevenpost stevenpost closed this Apr 9, 2024
@stevenpost stevenpost deleted the fix/yaml_config branch April 9, 2024 15:39
@stevenpost stevenpost restored the fix/yaml_config branch April 10, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants