Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider cleanup (safe part) #726

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Provider cleanup (safe part) #726

merged 6 commits into from
Apr 3, 2024

Conversation

stevenpost
Copy link
Contributor

This PR cleans up the provider.

A detailed list of changes:

  • Drop support for obsolete file locations
  • Drop old work-arounds
  • Simplify authentication logic in mongoshrc.js (making it a bit less error-prone)
  • Refactor out code for pre-2.6 config

@stevenpost
Remove redundant check
14f9ddf 
Since we are in the `else` clause and `port` already evaluates to false,
we can be pretty confident on how `!port` will evaluate.
@stevenpost
Drop support for old config location from is_master fact
53e5ee7
@stevenpost
Drop support for old config location from provider
7bc4210
@stevenpost
Remove work-around for non-json responses
c10d82e 
This was put in place for the `mongo` command in the provider. But we
now use a different provider.
@stevenpost
Simplify authenthication
d190478 
No need to switch between databases.
@stevenpost stevenpost mentioned this pull request Apr 2, 2024
Merged
@stevenpost
Remove support for pre-2.6 config
729d3d3 
The boolean check was there for old config. See commits
1bb1995
6cd09d1
@stevenpost stevenpost changed the title Provider cleanup Provider cleanup (safe part) Apr 2, 2024
@stevenpost stevenpost marked this pull request as ready for review April 2, 2024 15:57
@stevenpost stevenpost mentioned this pull request Apr 2, 2024
Merged
@witjoh witjoh merged commit ba8fb13 into voxpupuli:master Apr 3, 2024
24 checks passed
@stevenpost stevenpost deleted the provider_cleanup_safe branch April 3, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@witjoh witjoh witjoh approved these changes

@h-haaks h-haaks h-haaks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenpost @h-haaks @witjoh