Set version defaults with hiera data #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Specifying |
traylenator
force-pushed
the
hiera
branch
2 times, most recently
from
02e0005
to
ff72806
Compare
Merged
kenyon
approved these changes
Nov 29, 2023
|
@traylenator , can you resolve the merge conflicts? then i can merge this |
Sure - will take a look tomorrow. |
Use hiera module level data to specify default versions and if a repository should be configured. This will make adding new OSes easier.
With OS facts set the following error occured:
```
NoMethodError:
# undefined method `downcase' for nil:NilClass
# ./vendor/bundle/ruby/3.2.0/gems/puppet-8.3.1/lib/puppet/provider/service/init.rb:25:in `block in <top (required)>'
```
since the service provider could not be determined correctly.
zilchms
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Use hiera module level data to specify default versions and if a repository should be configured.
This will make adding new OSes easier.
2nd commit fixes some rpsec by adding facts so the service provider is detected correctly.