Add certbot-dns-ovh plugin support #195
Conversation
manifests/certonly.pp
Outdated
| $plugin_args = [ | ||
| "--cert-name '${title}' -d", | ||
| "'${_domains}'", | ||
| "--dns-ovh-credentials ${letsencrypt::plugin::dns_ovh::config_dir}/dns-ovh.ini", |
There was a problem hiding this comment.
Should the plugin declare a $config_file variable? Can be inside the body of the class. That way you don't rely on these two matching but can statically check it.
There was a problem hiding this comment.
I don't know exactly what you mean. Can you give me more details ?
There was a problem hiding this comment.
I meant something like (very shortened):
class letsencrypt::plugin::dns_ovh {
$config_file = "${letsencrypt::plugin::dns_ovh::config_dir}/dns-ovh.ini"
file { $config_file:
# ...
}
}Then you can use it here:
"--dns-ovh-credentials ${letsencrypt::plugin::dns_ovh::config_file}",There was a problem hiding this comment.
Ok, I changed $config_dir by $config_file in this PR
manifests/plugin/dns_ovh.pp
Outdated
| @@ -0,0 +1,59 @@ | |||
| # == Class: letsencrypt::plugin::dns_ovh | |||
There was a problem hiding this comment.
Could you format this using puppet-strings style?
There was a problem hiding this comment.
Yes, it's done here
Should I do another PR ?
There was a problem hiding this comment.
It's fine here. A separate PR to convert the rest of the module would be appreciated though :)
There was a problem hiding this comment.
Ok, next week I will probably have some time to do it !
I never write tests before but I'm gonna try. |
|
Any luck so far? I'd happy to make suggestions when you're stuck. |
|
Hi Ewoud, |
manifests/plugin/dns_ovh.pp
Outdated
| # | ||
| # @see https://certbot-dns-ovh.readthedocs.io | ||
| # | ||
| # === Parameters: |
There was a problem hiding this comment.
This is no longer needed with puppet-strings.
| # === Parameters: |
|
|
||
| Note: | ||
|
|
||
| For Debian based OS, this plugin is compatible from Debian 10 |
There was a problem hiding this comment.
Why is it not supported? If there are no packages, would it be better to set the package name to undef on those and add a check in the class that if manage_package is true, the package must be set?
enable acceptance with debian10
fix modulesync config file
…encies_versions Raise upper bound version of stdlib & vcsrepo
use puppet strings
use ACME API v2
package_name is a mandatory parameter. This means that the default value cannot be `undef`.
Previously, we had no hiera entry for this key for Debian 9 / Ubuntu 16.04. Instead we had it multiple times, for Debian 10 and Ubuntu 18.04. We can reduce it to a single occurance within the Debian.yaml for the whole os family.
add manifest to install dns-route53 plugin, along with tests
fix typo in renew example
modulesync 3.0.0 & puppet-lint updates
release 6.0.0
modulesync 3.1.0
This reverts commit 805f91d.
Pull Request (PR) description
Add dns-ovh support based on dns_rfc2136 implementation