Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update log4j2properties.erb for [%node_name]%markers #1071

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update log4j2properties.erb for [%node_name]%markers #1071

wants to merge 2 commits into from

Conversation

sferry
Copy link

@sferry sferry commented Feb 19, 2020

Pull request acceptance prerequisites:

  • Signed the CLA (if not already signed)
  • Rebased/up-to-date with base branch
  • Tests pass
  • Updated CHANGELOG.md with patch notes (if necessary)
  • Updated CONTRIBUTORS (if attribution is requested)

@sferry
update log4j2properties.erb for [%node_name]%markers
8a8eda9 
elasticsearch.log : [2019-06-20T00:45:20,052][WARN ][o.e.c.l.LogConfigurator  ] [] Some logging configurations have %marker but don't have %node_name. We will automatically add %node_name to the pattern to ease the migration for users who customize log4j2.properties but will stop this behavior in 7.0. You should manually replace `%node_name` with `[%node_name]%marker ` in these locations:
  /etc/elasticsearch/elastic-elk1/log4j2.properties

This is what this is doing.
@sferry
Merge pull request #1 from sferry/sferry-node_name-markers
9d71396 
update log4j2properties.erb for [%node_name]%markers
@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

Author of the following commits did not sign a Contributor Agreement:
8a8eda9, 9d71396

Please, read and sign the above mentioned agreement if you want to contribute to this project

@vox-pupuli-tasks
Copy link

Dear @sferry, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @sferry, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@phaedriel phaedriel mentioned this pull request Dec 31, 2022
Closed
@phaedriel phaedriel mentioned this pull request Jul 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge-conflicts tests-fail
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sferry @elasticmachine