Fix downloading when passwords contain spaces #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
commented
Jan 22, 2021
| params += ['--netrc-file', @netrc_file.path] | ||
| if resource[:username] =~ %r{\s} || resource[:password] =~ %r{\s} | ||
| Puppet.warning('Username or password contains a space. Unable to use netrc file to hide credentials') | ||
| account = [resource[:username], resource[:password]].compact.join(':') |
There was a problem hiding this comment.
This is the implementation from before #399
alexjfisher
force-pushed
the
issue_429
branch
2 times, most recently
from
b7423d2
to
fb3c803
Compare
This also adds our first acceptance tests to this module.
alexjfisher
force-pushed
the
issue_429
branch
from
fb3c803
to
0eaeeaa
Compare
|
There's a small chance that this is the fix for the issue reported in #429 |
bastelfreak
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds our first acceptance tests to this module.