Manage GitHub settings via Probot #654
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| repository: | ||
| private: false | ||
| has_issues: true | ||
| has_projects: false | ||
| has_wiki: false | ||
| has_downloads: true | ||
| default_branch: master | ||
| allow_squash_merge: true | ||
| allow_merge_commit: true | ||
| allow_rebase_merge: true | ||
| delete_branch_on_merge: true | ||
| archived: false | ||
|
|
||
| branches: | ||
| - name: master | ||
| protection: | ||
| required_pull_request_reviews: | ||
| required_approving_review_count: 1 | ||
| dismiss_stale_reviews: true | ||
| require_code_owner_reviews: true | ||
| required_status_checks: | ||
| strict: true | ||
| contexts: ['continuous-integration/travis-ci'] | ||
|
There was a problem hiding this comment. I think this doesn't work for our release workflow. Also not sure if there might be a difference between legacy open source Travis and the modern one. Might be that we have some modules using the modern one. There was a problem hiding this comment. @bastelfreak mentioned that the I do not know, if we are able to check the current Travis CI version, but it should be possible to configure multiple contexts like Travis CI and Jenkins. In the end it is an array, but I have to take a look at the docs, if this will be treated as There was a problem hiding this comment. as far as I know this will break our release process (that's why I tested this long time ago and had to remove the branch protection again). This will enforce that travis runs for every PR and only PRs are allowed for the protected branch. You cannot push anymore directly to master. This in general should be our goal, but our travis_release task directly pushes to master: If I remember corretly nobody can push to master, even admins. admins "only" have the power to merge PRs if travis is still running/failing. There was a problem hiding this comment. @bastelfreak I think you have missed my comment regarding I was able to merge a pull request, although the conditions for the Travis CI check were not fulfilled: I also was able to push to the master branch: This might be related to the I think it would be best if I make a template from the files and we start with some small changes in the There was a problem hiding this comment. It has to be tested by Travis, but Travis/Github identifies by commit. That means you can push it to a branch, get it tested and merged. Perhaps you can change the script to push to a There was a problem hiding this comment. I will remove the Thanks for the tip on |
||
| enforce_admins: true | ||
| restrictions: null | ||
| required_signatures: true | ||
| - name: modulesync | ||
| protection: | ||
| required_pull_request_reviews: null | ||
| required_status_checks: | ||
| strict: true | ||
| contexts: ['continuous-integration/travis-ci'] | ||
| enforce_admins: true | ||
| restrictions: null | ||
| required_signatures: true | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| .github/settings.yml @voxpupuli/project-maintainers | ||
|
|
||
| * @voxpupuli/collaborators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, but have we checked whether this is actually true? Or do you want to do that as part of the modulesync review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be possible to loop over
managed_modules.ymlto fetch the current values regardingprojectsandwiki.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many repositories use
projectsand / orwikibecause this is a default value during the creation process. I think we need to check this manually during themodulesyncand modify it if necessary via.sync.yml.