-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: image default versions #281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
I think only changing the default for teams-do is lower risk. Only adding 2GB to the image for the few customers that have added teams-do so far. |
Also, should get acknowledgement from all of CS before releasing this change (especially if we're gonna change plugins pod also) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I agree with stuart that just making this change for teams-do
might be the best way to go for now. This is primarily to run torch models which is a very heavy operation that should always be delegated and not run directly in the app/teams-plugins
@afoley587 - Is there a plan to also update the docker teams-do image default? |
Good point, updated as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @afoley587 !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump to 2.5.0
Co-authored-by: topher <[email protected]> Signed-off-by: afoley587 <[email protected]>
Co-authored-by: topher <[email protected]> Signed-off-by: afoley587 <[email protected]>
Co-authored-by: topher <[email protected]> Signed-off-by: afoley587 <[email protected]>
Co-authored-by: topher <[email protected]> Signed-off-by: afoley587 <[email protected]>
Signed-off-by: afoley587 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed some slight clarifications, otherwise looks good!
Co-authored-by: Eric Hofesmann <[email protected]> Signed-off-by: afoley587 <[email protected]>
Co-authored-by: Eric Hofesmann <[email protected]> Signed-off-by: afoley587 <[email protected]>
Co-authored-by: Eric Hofesmann <[email protected]> Signed-off-by: afoley587 <[email protected]>
Co-authored-by: Eric Hofesmann <[email protected]> Signed-off-by: afoley587 <[email protected]>
Rationale
Changes the
teams-do
image defaults to thefiftyone-teams-cv-full
image.Changes
Changes the
teams-do
image defaults to thefiftyone-teams-cv-full
image.Also issues warnings about the new image sizes.
Checklist
Testing