Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test scenarios for delegation #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

viktor-voitenko
Copy link

…ter delegation and vote cast

@jjranalli
Copy link
Contributor

  • about testCastVoteAfterDelegationAuthorities2, except the allowance check those assertions are verified on every castVote via castVoteBatchedAssertions. I suggest adding the allowance check in castVoteBatchedAssertions and removing the test altogether since it doesn't seem to add anything to existing tests.
  • same is valid for testChangeDelegatorBalanceAfterCastVote which unless doesn't add anything to existing tests so can be safely removed
  • minor note: forge formatting seems to not be working on file save. make sure to have NomicFoundation.hardhat-solidity VSCode extension installed for the moment to keep it consistent

@viktor-voitenko To proceed I suggest going through the test cases mentioned on notion, and implementing them in the repo if not already present

Base automatically changed from alligator-allowance-fix to main May 16, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants