Possibility to add an alert for iOS

[MayeuldP]

I added the possibility to set an alarm since there was none by default. It works for iOS, because in Android, it use the native calendar, and users already got reminder 5 or 10 minutes before any events on their calendar, but not on iOS if no alarm is set.

I just added a field alert, and manage the differences in ios/AddCalendarEvent.m and succeed to manage it thanks to EKAlarm.

You just have to pass a field alert in the eventConfig.

• 0 will set an alarm equal to startDate.
• 1 will set an alarm 5 minutes before startDate.
• 2 will set an alarm 30 minutes before startDate.
• 3 will set an alarm 60 minutes before startDate.

[MayeuldP]

Fell free to tell me if there's anything I forgot, or if you meet any troubles !

[vonovak]

Hi! Thanks for your time and your contribution. I have some comments regarding how this is implemented. Also please note your implementation allows only single reminder while there can be multiple defined.

I suggest you take a look at react-native-calendar-events which already offers this functionality and get inspired there. I think there is no need to reinvent the wheel - imo you can just copy the relevant code since the license allows to do so, and we'll credit the author in release notes.

[vonovak]

The options "0" ... "3" seem rather random - why not just pass the number of minutes from the JS side?

[MayeuldP]

Ahh, yeah I was quite agree but because I didn't see that react-native-calendar-events already managed that. I'll have a look to see how I can eventually implement it here ! Thank's !

[vonovak]

you're using alarmWithAbsoluteDate - let's consider the following scenario: user

1. creates an event for 2pm and adds an alert that should fire 30 minutes before
2. moves the event to 1:30pm
3. when does the alert fire and is it what the user expects?

I think this might be useful.

[vonovak]

take a good look at the code: there is a lot of duplicates - the ifs look more or less the same, with just small differences. It would be better to remove the duplications and perhaps extract this functionality into a separate function :)

[AndreyPatseiko]

Resolve conflicts and add functionality, please!

[arnaudambro]

yes please resolve the conflicts and merge !

[jordanwade]

Just wanted to share what is working for me to add alerts to iOS. As suggested above I'm using alarmWithRelativeOffset. This allows me a way to pass in any alert in minutes to options.

    if (options[_alert]) {
        int offset = [RCTConvert int:options[_alert]];
        NSTimeInterval alarmOffset = offset*-60;
        EKAlarm * alarm = [EKAlarm alarmWithRelativeOffset:alarmOffset];
        event.alarms = @[alarm];
    }

[vonovak]

@jordanwade would you be willing to open a PR? it'd be much appreciated, thanks!

[phatlaunchdeck]

Just wanted to share what is working for me to add alerts to iOS. As suggested above I'm using alarmWithRelativeOffset. This allows me a way to pass in any alert in minutes to options.

    if (options[_alert]) {
        int offset = [RCTConvert int:options[_alert]];
        NSTimeInterval alarmOffset = offset*-60;
        EKAlarm * alarm = [EKAlarm alarmWithRelativeOffset:alarmOffset];
        event.alarms = @[alarm];
    }

This works nicely on my testing as well, please open a PR :)

Also, would you mind implementing this to Android as well? Thanks!

[Jbarget]

Ah would love this feature! but wouldn't know where to start with adding the Android functionality, @MayeuldP @vonovak any ideas if or when Android might be added and this might get merged?

[vonovak]

hello @Jbarget and thanks for commenting, as explained in the readme, I no longer actively develop the package. If you want to add new features, you can hire me, as explained https://github.com/vonovak/react-native-add-calendar-event#maintenance-notice

thank you

[chococrypto]

Resolve conflicts and add functionality, please!