Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: use slices.Backward from Go 1.23 #1388

Merged
merged 1 commit into from
Sep 17, 2024
Merged

all: use slices.Backward from Go 1.23 #1388

merged 1 commit into from
Sep 17, 2024

Conversation

mvdan
Copy link
Contributor

@mvdan mvdan commented Sep 11, 2024

(see commit message)

@coveralls
Copy link

coveralls commented Sep 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10898929093

Details

  • 10 of 21 (47.62%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.001%) to 62.266%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tree/arbo/proof.go 6 7 85.71%
vochain/indexer/vote.go 0 2 0.0%
vochain/results/compute.go 4 7 57.14%
api/helpers.go 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
tree/arbo/proof.go 1 86.36%
vochain/results/compute.go 1 70.27%
Totals Coverage Status
Change from base Build 10898739349: -0.001%
Covered Lines: 16828
Relevant Lines: 27026
💛 - Coveralls

@mvdan @altergui
all: use slices.Backward from Go 1.23
a8a0a05 
And simplify the surrounding code slightly.
@p4u p4u merged commit baef75f into vocdoni:main Sep 17, 2024
11 checks passed
@mvdan mvdan deleted the go1.23-more branch December 3, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altergui altergui altergui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvdan @coveralls @altergui @p4u