extend faucet package support for other transactions #1380
Merged
+415
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p4u
force-pushed
the
f/extend_faucet_package_usage
branch
3 times, most recently
from
5ef52f8 to
37e269c
Compare
Pull Request Test Coverage Report for Build 10735680045Details
💛 - Coveralls |
altergui
approved these changes
Sep 5, 2024
Comment on lines
+509
to
+517
| // should work, try using a faucet package for a set account info tx | ||
| // first create the account (and check balance is 0, because tx cost 200) | ||
| faucetPkg, err = GenerateFaucetPackage(signers[0], signers[9].Address(), 200) | ||
| qt.Assert(t, err, qt.IsNil) | ||
| qt.Assert(t, testSetAccountTx(t, | ||
| signers[9], signers[9].Address(), faucetPkg, app, "", uint32(0), true), | ||
| qt.IsNil, | ||
| ) |
There was a problem hiding this comment.
maybe it would be interesting to include as well 199, so the faucet would not produce enough balance to actually execute the transaction. this might trigger weird bugs, not now (due to the canPayForTx check 🙌) but the test would catch future regressions
There was a problem hiding this comment.
i added this test i mentioned, and also another corner case test, where none of the current balance OR the faucet are enough to cover the txcost, but combined they do.
altergui
force-pushed
the
f/extend_faucet_package_usage
branch
from
e4ba715 to
02e6e13
Compare
|
found a small bug, fixing it |
|
ok, feel free to merge it yourself when ready |
|
i pushed the fix, i'm still extending and readapting the tests, will merge as soon as i finish |
p4u
commented
Sep 6, 2024
Faucet package can now be used on NewProcess, SetAccount, SetProcess and SetSik related transactions. Signed-off-by: p4u <[email protected]>
altergui
force-pushed
the
f/extend_faucet_package_usage
branch
from
559b0fe to
4e9a11e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faucet package can now be used on NewProcess, SetAccount, SetProcess and SetSik related transactions.