Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/indexer drop tx id #1371

Closed
wants to merge 2 commits into from
Closed

feat/indexer drop tx id #1371

wants to merge 2 commits into from

Conversation

altergui
Copy link
Contributor

@altergui altergui commented Aug 27, 2024 •
edited
Loading 

indexer: drop concept of transaction id, hash is now the primary key

 * api: remove endpoint /chain/transactions/reference/index/{index}

@altergui altergui force-pushed the feat/indexer-drop-tx-id branch 2 times, most recently from 3a59d53 to dbbd055 Compare August 30, 2024 13:06
@coveralls
Copy link

coveralls commented Aug 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10664370687

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 62.34%
Files with Coverage Reduction New Missed Lines %
vochain/transaction/admin_tx.go 2 48.81%
vochain/transaction/transaction.go 2 59.23%
Totals Coverage Status
Change from base Build 10522335386: 0.1%
Covered Lines: 16510
Relevant Lines: 26484
💛 - Coveralls

@altergui altergui force-pushed the feat/indexer-drop-tx-id branch from dbbd055 to 0f35bd6 Compare August 30, 2024 13:24
@altergui
indexer: drop concept of transaction id, hash is now the primary key
194de89 
 * api: remove endpoint /chain/transactions/reference/index/{index}

indexer migration:
 * 0013_recreate_table_transactions.sql
@altergui altergui force-pushed the feat/indexer-drop-tx-id branch from 0f35bd6 to 194de89 Compare September 2, 2024 08:59
@altergui altergui mentioned this pull request Sep 2, 2024
Open
@altergui
api: rename /chain/transactions fields
60b68ee 
renames:
  * transactionHash -> hash
  * blockHeight -> height
  * transactionIndex -> index
  * transactionType -> type

affected endpoints:
  /chain/blocks/{height}/transactions/page/{page}
  /chain/transactions/page/{page}
  /chain/transactions
  /chain/transactions/{height}/{index}
  /chain/transactions/reference/{hash}
@altergui
Copy link
Contributor Author

altergui commented Sep 4, 2024

this was included in #1329

@altergui altergui closed this Sep 4, 2024
@mvdan mvdan deleted the feat/indexer-drop-tx-id branch December 3, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@altergui @coveralls