Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: endpoint /elections can now filter startDate and endDate #1361

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

altergui
Copy link
Contributor

@altergui altergui commented Aug 8, 2024

No description provided.

@altergui altergui force-pushed the feat/api-elections-date-filters branch from 303a022 to 3ac33c5 Compare August 9, 2024 12:38
@altergui altergui self-assigned this Aug 9, 2024
@altergui altergui force-pushed the feat/api-elections-date-filters branch from 3ac33c5 to ba8f132 Compare August 9, 2024 12:48
@coveralls
Copy link

coveralls commented Aug 9, 2024

Pull Request Test Coverage Report for Build 10457507994

Details

  • 67 of 77 (87.01%) changed or added relevant lines in 5 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.004%) to 62.697%

Changes Missing Coverage Covered Lines Changed/Added Lines %
vochain/indexer/process.go 4 5 80.0%
api/elections.go 42 44 95.45%
api/helpers.go 10 17 58.82%
Files with Coverage Reduction New Missed Lines %
vochain/transaction/admin_tx.go 2 48.81%
vochain/transaction/transaction.go 2 59.23%
Totals Coverage Status
Change from base Build 10452821442: -0.004%
Covered Lines: 16473
Relevant Lines: 26274

💛 - Coveralls

@altergui altergui force-pushed the feat/api-elections-date-filters branch 2 times, most recently from 3b5d234 to 59bf278 Compare August 19, 2024 16:03
@altergui altergui changed the title api: endpoint /elections can now filter startDate and endDate (WIP) api: endpoint /elections can now filter startDate and endDate Aug 19, 2024
@altergui altergui marked this pull request as ready for review August 19, 2024 16:27
this includes a refactor of parseElectionParams since the args list went wild

notably, the indexer.ProcessList method was not refactored.
@altergui altergui force-pushed the feat/api-elections-date-filters branch from 59bf278 to cd62600 Compare August 19, 2024 16:48
@altergui altergui merged commit cd62600 into main Aug 20, 2024
28 checks passed
@altergui altergui deleted the feat/api-elections-date-filters branch August 20, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants