Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused structs in indexer db models #1165

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

mariajdab
Copy link
Contributor

We can use the sqlc tag omit_unused_structs: true to avoid create models that are not being used in any part of the code

@mariajdab mariajdab requested review from p4u, mvdan and altergui October 25, 2023 03:36
@coveralls
Copy link

coveralls commented Oct 25, 2023

Pull Request Test Coverage Report for Build 6648385844

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 62.197%

Files with Coverage Reduction New Missed Lines %
vochain/state/cache.go 2 61.54%
Totals Coverage Status
Change from base Build 6646214448: -0.009%
Covered Lines: 14092
Relevant Lines: 22657

💛 - Coveralls

@mariajdab mariajdab force-pushed the indexer/use-omit_unused_structs-tag branch from 6312c34 to e53c04c Compare October 26, 2023 01:45
@p4u p4u merged commit e223f03 into main Oct 27, 2023
11 checks passed
@p4u p4u deleted the indexer/use-omit_unused_structs-tag branch October 27, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants