fixup! fixup! extend faucet package support for other transactions

add more tests to TestSetAccountTx

vochain/account_test.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"math/rand"
+	"regexp"
 	"testing"
 
 	cometabcitypes "github.com/cometbft/cometbft/abci/types"
@@ -539,6 +540,44 @@ func TestSetAccountTx(t *testing.T) {
 	qt.Assert(t, signer9Account.Balance, qt.DeepEquals, uint64(1))
 	qt.Assert(t, signer9Account.Nonce, qt.DeepEquals, uint32(1))
 	qt.Assert(t, signer9Account.InfoURI, qt.CmpEquals(), infoURI3)
+
+	// third should not work: try using an insufficiente faucet package (100) for a set account info tx
+	// because tx cost 200
+	faucetPkg, err = GenerateFaucetPackage(signers[0], signers[9].Address(), 100)
+	qt.Assert(t, err, qt.IsNil)
+	infoURI4 := "ipfs://newInfoUri4"
+	qt.Assert(t, testSetAccountTx(t,
+		signers[9], signers[9].Address(), faucetPkg, app, infoURI4, uint32(1), false),
+		qt.ErrorMatches, regexp.MustCompile(".*"+state.ErrNotEnoughBalance.Error()),
+	)
+
+	signer9Account, err = app.State.GetAccount(signers[9].Address(), false)
+	qt.Assert(t, err, qt.IsNil)
+
+	// the result should be the 100 tokens are now added to the balance, but the infoURI remains unchanged.
+	qt.Assert(t, signer9Account, qt.IsNotNil)
+	qt.Assert(t, signer9Account.Balance, qt.DeepEquals, uint64(101))
+	qt.Assert(t, signer9Account.Nonce, qt.DeepEquals, uint32(1))
+	qt.Assert(t, signer9Account.InfoURI, qt.CmpEquals(), infoURI3)
+
+	// now this should work: try again using a small faucet package (120) for a set account info tx
+	// but adding faucet (120) + balance (101) is enough to cover the tx cost of 200
+	faucetPkg, err = GenerateFaucetPackage(signers[0], signers[9].Address(), 120)
+	qt.Assert(t, err, qt.IsNil)
+	qt.Assert(t, testSetAccountTx(t,
+		signers[9], signers[9].Address(), faucetPkg, app, infoURI4, uint32(1), false),
+		qt.IsNil,
+	)
+
+	signer9Account, err = app.State.GetAccount(signers[9].Address(), false)
+	qt.Assert(t, err, qt.IsNil)
+
+	// the resulting balance should be 21 (and the infoURI is updated)
+	// i.e. the tokens from balance + faucet (120+101=221) minus the consumed txcost (200),
+	qt.Assert(t, signer9Account, qt.IsNotNil)
+	qt.Assert(t, signer9Account.Balance, qt.DeepEquals, uint64(21))
+	qt.Assert(t, signer9Account.Nonce, qt.DeepEquals, uint32(2))
+	qt.Assert(t, signer9Account.InfoURI, qt.CmpEquals(), infoURI4)
 }
 
 func testSetAccountTx(t *testing.T,