fix: WIP attempt to fix path resolution for windows

vnphanquang · Nov 21, 2024 · 8e210e8 · 8e210e8
1 parent 077bd47
commit 8e210e8
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -18,7 +18,8 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
+        # os: [ubuntu-latest, macos-latest, windows-latest]
+        os: [windows-latest]
     timeout-minutes: 5
     steps:
       - name: Checkout repository

diff --git a/package.json b/package.json
@@ -44,7 +44,7 @@
 		"prepublishOnly": "publint",
 		"lint": "eslint src/**/*",
 		"test": "vitest --coverage",
-		"ci:test": "vitest run --coverage",
+		"ci:test": "vitest run --coverage --allowOnly",
 		"ci:version": "changeset version && pnpm install --no-frozen-lockfile",
 		"ci:publish": "changeset publish && pnpm install"
 	},

diff --git a/src/plugin.js b/src/plugin.js
@@ -1,4 +1,5 @@
 import fs from 'fs';
+import path from 'path';
 
 import { icons } from '@phosphor-icons/core';
 import { resolve } from 'import-meta-resolve';
@@ -51,10 +52,14 @@ export default createPlugin.withOptions(
 
 					let url = 'icon-not-found';
 					if (ICON_SET.has(name) && VARIANTS.includes(weight)) {
-						let filepath = resolve(
-							`@phosphor-icons/core/assets/${weight}/${name}${weight === 'regular' ? '' : `-${weight}`}.svg`,
-							import.meta.url,
-						).replace('file://', '');
+						let filepath = path.resolve(
+							resolve(
+								`@phosphor-icons/core/assets/${weight}/${name}${weight === 'regular' ? '' : `-${weight}`}.svg`,
+								import.meta.url,
+							).replace('file://', ''),
+						);
+						console.log('dirname: ', import.meta.dirname);
+						console.log('icon:', filepath);
 
 						if (fs.existsSync(filepath)) {
 							const svgStr = fs.readFileSync(filepath, { encoding: 'base64' });

diff --git a/tests/plugin.test.ts b/tests/plugin.test.ts
@@ -16,7 +16,7 @@ interface Run {
 }
 
 function tests(run: Run, version: number) {
-	test('default', async function ({ expect }) {
+	test.only('default', async function ({ expect }) {
 		const result = await run([...COMMON_CANDIDATES, 'ph', 'ph-[info]']);
 		await expect(result).toMatchFileSnapshot(
 			path.resolve(import.meta.dirname, '__snapshots__', `v${version}/default.css`),