Add batch APIs for multiple tags to object #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
embano1
commented
Dec 15, 2020
embano1
commented
Dec 15, 2020
embano1
changed the title
|
Please hold Doug, found a minor glitch in one test which passed but in the wrong way :) |
embano1
commented
Dec 16, 2020
embano1
commented
Dec 16, 2020
- Add attach-multiple-tags-to-object and detach-multiple-tags-from-object APIs - Add BatchError(s) types - Add minimum simulator APIs (see note below) - Add/update comments to describe error behavior in detail - Add black-box tests (against simulator) Tested against vCenter 6.7U3 which has the following behavior: - Missing/invalid object reference: 403 Forbidden - No valid REST session: 401 Unauthorized - No tagging permissions: ServerFaultCode: Permission to perform this operation was denied - Tag not found: 200 with individual cis.tagging.objectNotFound.error in response - Cardinality violation: 200 with cis.tagging.attach.invalidArgument.cardinality.error Note that the existing simulator APIs currently don't support all these failure codes Fixes: #2208 Related: #2210 Signed-off-by: Michael Gasch <[email protected]>
|
Done, ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the missing multiple-tags-to-object (attach/detach) APIs which are important for efficiency and performance especially in large environments (many tags/objects) and environments with high churn (Kubernetes controllers, event-driven systems).
The following changes were made:
Example output handled in a
main.gowith thelogpackage where some tags could not be assigned to a valid reference:Tested against vCenter 6.7U3 which has the following behavior:
403 Forbidden401 UnauthorizedServerFaultCode: Permission to perform this operation was denied200 with individual cis.tagging.objectNotFound.error in response200 with cis.tagging.attach.invalidArgument.cardinality.errorNote that the existing simulator APIs currently don't support all these failure codes
Fixes: #2208
Related: #2210
Signed-off-by: Michael Gasch [email protected]