Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(breadcrumbs): Add STYLES.md file for custom CSS properties & classes #1669

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andyfeds
Copy link
Contributor

@andyfeds andyfeds commented Jan 15, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-2533

What is the new behavior?

Documented the custom CSS properties and classes for the breadcrumbs component.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Jan 15, 2025

👋 @andyfeds,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@andyfeds andyfeds changed the title chore(breadcrumbs): Add STYLES.md file for custom CSS properties and … chore(breadcrumbs): Add STYLES.md file for custom CSS properties & classes Jan 15, 2025
@andyfeds andyfeds self-assigned this Jan 15, 2025
@andyfeds andyfeds requested a review from a team January 15, 2025 08:59
@andyfeds andyfeds force-pushed the breadcrumbs-CDE-2533 branch from e1de8a4 to 46f2ff1 Compare January 16, 2025 05:05
Copy link
Member

@sandeepkulki sandeepkulki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving CSS changes

Comment on lines +9 to +11
| --clr-breadcrumb-font-weight | Breadcrumb item font weight |
| --clr-breadcrumb-font-size | Breadcrumb item font size |
| --clr-breadcrumb-line-height | Breadcrumb item line height |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those 3 properties are not used anywhere. You can safely delete them from code as well.

Suggested change
| --clr-breadcrumb-font-weight | Breadcrumb item font weight |
| --clr-breadcrumb-font-size | Breadcrumb item font size |
| --clr-breadcrumb-line-height | Breadcrumb item line height |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants