Skip to content

Conversation

@rahul-tuli
Copy link
Collaborator

Adds a Claiming work section to CONTRIBUTING.md to help with open source contributions!

@mergify mergify bot added the documentation Improvements or additions to documentation label Feb 11, 2026
@github-actions
Copy link

📦 Build Artifacts Available
The build artifacts (`.whl` and `.tar.gz`) have been successfully generated and are available for download: https://github.com/vllm-project/speculators/actions/runs/21911456642/artifacts/5469392394.
They will be retained for up to 30 days.
Commit: 36a4ba7

@rahul-tuli rahul-tuli requested a review from HDCharles February 11, 2026 17:51
@rahul-tuli rahul-tuli self-assigned this Feb 11, 2026
Copy link
Collaborator

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My problem with this is that it reads a bit aggressively

@HDCharles
Copy link
Collaborator

HDCharles commented Feb 11, 2026

Agree it's a bit aggressive, maybe "should" instead of "must"


**Read this section before starting any significant work.**

If you plan to work on a large feature or substantial refactor, the issue **must be officially assigned to you by a maintainer** before you begin implementation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you plan to work on a large feature or substantial refactor, the issue **must be officially assigned to you by a maintainer** before you begin implementation.
If you plan to work on a large feature or substantial refactor, the issue **should be officially assigned to you by a maintainer** before you begin implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants