Skip to content

Manage 'quality-failed' label in mergify configuration #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsikka wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −0
Open

Manage 'quality-failed' label in mergify configuration #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/mergify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,29 @@ pull_request_rules:
label:
remove:
- needs-rebase

- name: add quality-failed label
conditions:
- label != stale
- check-failure = quality-check
Copy link
Collaborator

@fynnsu fynnsu Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this needs to match the check name exactly

I think it might be:
quality-checks (3.10)

- -closed
actions:
label:
add:
- quality-failed
comment:
message: |
The quality checks have failed. Please run `make style` and `make quality` under
the root directory to adddress the lint failures. You will need to install the
Copy link
Collaborator

@fynnsu fynnsu Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the root directory to adddress the lint failures. You will need to install the
the root directory to address the lint failures. You will need to install the

dev optional install to get the required linting packages:
https://github.com/vllm-project/speculators/blob/main/CONTRIBUTING.md

- name: remove quality-failed label
conditions:
- label != stale
- -check-failure = quality-check
- -closed
actions:
label:
remove:
- quality-failed