Open
Conversation
Signed-off-by: guangli.bao <guangli.bao@daocloud.io>
Signed-off-by: guangli.bao <guangli.bao@daocloud.io>
Collaborator
|
Please fill in the necessary components of the PR template. Especially the certification that the work is your own, and the AI section if applicable. |
sjmonson
requested changes
Jan 19, 2026
Collaborator
sjmonson
left a comment
There was a problem hiding this comment.
Needs python -m mdformat docs/examples/practice_on_audio_benchmark.md to make lintier happy.
| In a new terminal, start the mock server using: | ||
|
|
||
| ```bash | ||
| guidellm mock-server --host 0.0.0.0 --port 8080 |
Collaborator
There was a problem hiding this comment.
Since everything below refers to 127.0.0.1, just bind to the one address:
Suggested change
| guidellm mock-server --host 0.0.0.0 --port 8080 | |
| guidellm mock-server --host 127.0.0.1--port 8080 |
Comment on lines
+19
to
+21
| git clone https://github.com/vllm-project/guidellm.git | ||
| cd guidellm | ||
| pip install guidellm |
Collaborator
There was a problem hiding this comment.
Suggested change
| git clone https://github.com/vllm-project/guidellm.git | |
| cd guidellm | |
| pip install guidellm | |
| pip install guidellm |
| -F "file=@/hello.mp3" | ||
| ``` | ||
|
|
||
| #### 1.7 Benchmark Test Data Generation |
Collaborator
There was a problem hiding this comment.
Since you install gTTS above, why not use it to generate a dataset here? Something like:
from gtts import gTTS
from faker import Faker
import wave
...
for i in range(count):
prompt = faker.text(max_nb_chars=100)
tts = gTTS(prompt)
tts.save(audio_filename)
...I did not do any verification on this so it may not work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Provide audio benchmark practice guide based on mock-server.
Test Plan
Related Issues
Use of AI
## WRITTEN BY AI ##)