Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v: missing -skip-unused fixes #22978

Merged
merged 29 commits into from
Nov 27, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Nov 26, 2024

This PR fixes some missing break when enabling -skip-unused as default.

Huly®: V_0.6-21419

@medvednikov
Copy link
Member

medvednikov commented Nov 27, 2024

@felipensp we can merge this for now by commenting out res.skip_unused = true in pref.v

To make sure all tests pass otherwise and so that we don't work on the same thing.

@felipensp
Copy link
Member Author

felipensp commented Nov 27, 2024

@felipensp we can merge this for now by commenting out res.skip_unused = true in pref.v

To make sure all tests pass otherwise and so that we don't work on the same thing.

Ok @medvednikov re-commenting again...

@felipensp felipensp marked this pull request as ready for review November 27, 2024 11:47
@medvednikov
Copy link
Member

>    failed   1/1 times, doing `'/home/runner/work/v/v/v' -d no_backtrace -skip-unused run 'vlib/v/tests/skip_unused/aggregate_call.vv'`
 FAIL  [21/40]   167.017 ms vlib/v/tests/skip_unused/aggregate_call.vv
============
failed cmd: '/home/runner/work/v/v/v' -d no_backtrace -skip-unused run 'vlib/v/tests/skip_unused/aggregate_call.vv'
expected_out_path: vlib/v/tests/skip_unused/aggregate_call.skip_unused.run.out
============
expected (len:     0, hash: 0):

============
found    (len:   844, hash: -1330108580):
================== C compilation error (from tcc): ==============
cc: /tmp/v_1001/tsession_7f29a5053b80_01JDPQB0ZNC7D1HSHVPFW998WE/aggregate_call.01JDPQFMHCARCFTQ8RPHSJ1WC4.tmp.c:1386: warning: implicit declaration of function '__new_array_with_default_noscan'
cc: /tmp/v_1001/tsession_7f29a5053b80_01JDPQB0ZNC7D1HSHVPFW998WE/aggregate_call.01JDPQFMHCARCFTQ8RPHSJ1WC4.tmp.c:1386: error: '{' expected (got ";")
=================================================================

@felipensp
Copy link
Member Author

image

@medvednikov
Copy link
Member

Great job as always!

@medvednikov
Copy link
Member

>    failed   1/1 times, doing `'/home/runner/work/v/v/v' -d no_backtrace -skip-unused run 'vlib/v/tests/skip_unused/println_os_executable.vv'`
 FAIL  [36/40]   331.977 ms vlib/v/tests/skip_unused/println_os_executable.vv
============
failed cmd: '/home/runner/work/v/v/v' -d no_backtrace -skip-unused run 'vlib/v/tests/skip_unused/println_os_executable.vv'
expected_out_path: vlib/v/tests/skip_unused/println_os_executable.skip_unused.run.out
============
expected (len:    21, hash: -[549](https://github.com/vlang/v/actions/runs/12052778293/job/33606890108?pr=22978#step:14:550)076427):
println_os_executable
============
found    (len:   990, hash: 1157929151):
================== C compilation error (from /home/runner/work/v/v/thirdparty/tcc/tcc.exe): ==============
cc: /tmp/v_1001/tsession_7f738ec88b80_01JDQJ51SZB2GR8Z018TYY3307/println_os_executable.01JDQJB7Q0CC7FET1H4CJY9NES.tmp.c:4999: warning: cast between pointer and integer of different size
cc: /home/runner/work/v/v/thirdparty/tcc/lib/libgc.a: error: 'GC_noop1_ptr' defined twice
cc: tcc: error: undefined symbol 'charptr_vstring_literal'

@spytheman spytheman merged commit ae4a904 into vlang:master Nov 27, 2024
72 checks passed
@felipensp felipensp deleted the fix_skip_unused_enable_all branch November 27, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants