Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builtin: fix string.find_between(), when not found end string return '' #21670

Merged
merged 3 commits into from
Jun 12, 2024
Merged

builtin: fix string.find_between(), when not found end string return '' #21670

merged 3 commits into from
Jun 12, 2024

Conversation

kbkpbot
Copy link
Contributor

@kbkpbot kbkpbot commented Jun 12, 2024

find_between returns the string found between start string and end string.

When end string not found, should return '', not the rest of string.

@spytheman
Copy link
Member

Please add a test case for it too.

spytheman
spytheman approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@spytheman spytheman merged commit 02f6562 into vlang:master Jun 12, 2024
76 checks passed
raw-bin pushed a commit to raw-bin/v that referenced this pull request Jul 2, 2024
@kbkpbot @raw-bin
builtin: fix string.find_between(), when not found end string return …
5084f42 
…'' (vlang#21670)
@kbkpbot kbkpbot deleted the find_between branch October 3, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbkpbot @spytheman