net.http: implement http.download_file_with_progress/2, saving each chunk, as it is received, without growing the memory usage #21633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ig content to a file, by saving each chunk as it is received, without growing the memory usage
…d, eta, and bytes already downloaded
spytheman
changed the title
|
On this PR: On master, for the same file ~15MB file, the memory usage is several times higher: |
|
Great job! 🎉 |
Thank you. |
|
Very nice work - as always. |
raw-bin
pushed a commit
to raw-bin/v
that referenced
this pull request
Jul 2, 2024
…hunk, as it is received, without growing the memory usage (vlang#21633)
dumblob
reviewed
Jul 29, 2024
| mut req := prepare(config)! | ||
| d.on_start(mut req, path)! | ||
| response := req.do()! | ||
| d.on_finish(req, response)! |
There was a problem hiding this comment.
@spytheman great work, thanks!
Do you think it would be wise to guarantee on_finish() gets always called if on_start() finished successfully by defering it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v download(off by default).