builtin: update last_index_u8, deprecate index_u8_last string methods, make consistent with last_index
#21604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
approved these changes
May 30, 2024
spytheman
reviewed
May 30, 2024
ttytm
force-pushed
the
builtin/last-index-u8
branch
from
ae04a05 to
c73289e
Compare
ttytm
force-pushed
the
builtin/last-index-u8
branch
from
898061b to
90bcb56
Compare
raw-bin
pushed a commit
to raw-bin/v
that referenced
this pull request
Jul 2, 2024
…hods, make consistent with `last_index` (vlang#21604)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
index_u8_last=>last_index_u8method and deprecates the former to be consistent with the recent switch made by Alex fromindex_lasttolast_index. It is also consistent with the Go func equivalents.