orm: fix subquery without where expr

[felipensp]

Fix #21595

[juan-db]

I think there's a bigger problem here. At some point deep select was implemented so select statements will automatically retrieve children as well, but as soon as you have a deeper nested relationship, you would get the panic from the original issue. I think the ORM feature needs a way for you to explicitly load children.

[spytheman]

I think there's a bigger problem here. At some point deep select was implemented so select statements will automatically retrieve children as well, but as soon as you have a deeper nested relationship, you would get the panic from the original issue. I think the ORM feature needs a way for you to explicitly load children.

Please file a separate issue for that, with an example.

The PR afaik works as it is, the changes in it seem logical to me, and it does fix the problem described in your original issue. The only thing it lacks to no longer be a draft, is a test to prevent silent regressions in the future.

#0 17:53:44 ^ fix_subexpr_where /v/oo>v run z.v
[Parent{
    id: 1
    name: 'first parent'
    children: [Child{
        id: 1
        name: 'first child'
        parent_id: 1
        babies: []
    }, Child{
        id: 2
        name: 'second_child'
        parent_id: 1
        babies: []
    }]
}]

[juan-db]

My main concern is the where_expr field actually does have a value (id ==), it's just not a valid value. This likely points to a logic error somewhere.

[juan-db]

I've created a new issue so I'm happy with having this PR merged when ready.

[medvednikov]

Merged, thanks.