vdoc: fix regression on example comments #21226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttytm
force-pushed
the
vdoc/fix-example-regression
branch
from
416dc03 to
8bd5b2b
Compare
|
@spytheman Would the CI failure here resolve itself after a rebase/merge? |
Not sure, I do not understand why it failed in the first place, since I do not see anything platform specific in the change here. Lets rebase it, and see if it will repeat. |
ttytm
force-pushed
the
vdoc/fix-example-regression
branch
from
8bd5b2b to
88714e7
Compare
This reverts commit d9931e1.
|
The tests for the example output is still problematic with Ubuntu Docker MUSL CI. If thats okay not adding the test here and just restoring the correct behaviour then lets do it. It's a simple change that can get a little of coverage due to it's blame history. |
ttytm
changed the title
This reverts commit 88714e7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for a regression that happend due to accidentally leaving merge methods changed when working #21220. The symptom is that examples are part of the comment text
Adds tests for doc comment examples. The main coverage here is that there are no duplicates in of the example comments.