cgen: fix missing call to a function returning option, when called in…

…side a print (fix #21616) (#21623)
vlang · Jun 1, 2024 · ca55da6 · ca55da6
1 parent bb3505f
commit ca55da6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/vlib/v/gen/c/str.v b/vlib/v/gen/c/str.v
@@ -92,6 +92,12 @@ fn (mut g Gen) gen_expr_to_string(expr ast.Expr, etype ast.Type) {
 		g.expr(expr)
 		g.write(' ? _SLIT("true") : _SLIT("false")')
 	} else if sym.kind == .none_ || typ == ast.void_type.set_flag(.option) {
+		if expr is ast.CallExpr {
+			stmt_str := g.go_before_last_stmt()
+			g.expr(expr)
+			g.writeln(';')
+			g.write(stmt_str)
+		}
 		g.write('_SLIT("<none>")')
 	} else if sym.kind == .enum_ {
 		if expr !is ast.EnumVal {

diff --git a/vlib/v/tests/print_void_ret_test.v b/vlib/v/tests/print_void_ret_test.v
@@ -0,0 +1,10 @@
+fn foo(mut a &int) ? {
+	println('XXX')
+	a++
+}
+
+fn test_main() {
+	mut a := 1
+	println(foo(mut &a))
+	assert a == 2
+}