Race condition when closing both server and client at the same time#43
Open
yyewolf wants to merge 1 commit intovjeantet:masterfrom
Open
Race condition when closing both server and client at the same time#43yyewolf wants to merge 1 commit intovjeantet:masterfrom
yyewolf wants to merge 1 commit intovjeantet:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a weird issue with test not working from time to time, turns out there's a race condition if you close both a server and a client at the same time.
Take this example :
In this case, the goroutine might close the client channel, but receive the server closed message first, meaning that it would try to send to the closed channel.