Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Admin configuration #130

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix: Admin configuration #130

merged 1 commit into from
Jul 23, 2024

Conversation

KadirBalku
Copy link
Contributor

Hi, the provided keys for admin configuration should be as proposed in this PR

@KadirBalku KadirBalku added bug Something isn't working Priority: Low This issue can be considered with enough idle time. labels Jul 22, 2024
sveneberth
sveneberth approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@sveneberth sveneberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@sveneberth sveneberth merged commit ccf12fc into viur-framework:main Jul 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sveneberth sveneberth sveneberth approved these changes

@phorward phorward Awaiting requested review from phorward

Assignees
No one assigned
Labels
bug Something isn't working Priority: Low This issue can be considered with enough idle time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KadirBalku @sveneberth