Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cicd): Extend default cloudbuild.yaml for App Engine deployments #129

Merged
merged 5 commits into from
Jul 26, 2024
Merged

feat(cicd): Extend default cloudbuild.yaml for App Engine deployments #129

merged 5 commits into from
Jul 26, 2024

Conversation

Grashalmbeisser
Copy link
Contributor

@Grashalmbeisser Grashalmbeisser commented Jun 25, 2024 •
edited by sveneberth
Loading

Add cloud logging options

@sveneberth sveneberth changed the title Added CLOUD_LOGGING_ONLY Flag for custom Gcloudserviceaccount Support feat(cicd): Add default cloudbuild.yaml for App Engine deployments Jul 9, 2024
sveneberth
sveneberth reviewed Jul 9, 2024
View reviewed changes
Copy link
Member

@sveneberth sveneberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, The ignite repo has been renamed for a while and the spelling of the google products wasnt correct. Beside this please make the branch mergeable, it has currently conflicts.

cloudbuild.yaml Outdated Show resolved Hide resolved
cloudbuild.yaml Outdated Show resolved Hide resolved
cloudbuild.yaml Outdated Show resolved Hide resolved
@sveneberth sveneberth added feature New feature or request Priority: Medium This issue may be useful, and needs some attention. ci/cd labels Jul 9, 2024
sveneberth
sveneberth requested changes Jul 23, 2024
View reviewed changes
Copy link
Member

@sveneberth sveneberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Grashalmbeisser Please resolve the merge conflict

@sveneberth sveneberth changed the title feat(cicd): Add default cloudbuild.yaml for App Engine deployments feat(cicd): Extend default cloudbuild.yaml for App Engine deployments Jul 26, 2024
@sveneberth sveneberth merged commit 98351a9 into viur-framework:main Jul 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phorward phorward phorward approved these changes

@sveneberth sveneberth sveneberth approved these changes

Assignees
No one assigned
Labels
ci/cd feature New feature or request Priority: Medium This issue may be useful, and needs some attention.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Grashalmbeisser @sveneberth @phorward