Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): remove quotes from string values in test.each object-variable #6403

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LuciNyan
Copy link
Contributor

@LuciNyan LuciNyan commented Aug 26, 2024

Description

Closes: #5946

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@LuciNyan LuciNyan changed the title feat(utils): remove quotes from string values in test.each object-variable [WIP] feat(utils): remove quotes from string values in test.each object-variable Aug 26, 2024
Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5b414a4
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66cc88121b135d00083eac94
😎 Deploy Preview https://deploy-preview-6403--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LuciNyan LuciNyan marked this pull request as ready for review August 26, 2024 13:50
@LuciNyan LuciNyan changed the title [WIP] feat(utils): remove quotes from string values in test.each object-variable feat(utils): remove quotes from string values in test.each object-variable Aug 26, 2024
Copy link
Member

@sheremet-va sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5946 only talks about test.each use case. This PR affects every string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why test.each object-variable for string data type has quotes?
2 participants