queryExecutionHook OnQueryCompleted #18598
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
QueryExecutionHook
interface which runsProcessQueryCompleted
when a query is completed (byExecute
) in the vttablet. By default, this will do nothing, but it will allow users to implementQueryExecutionHook
and do whatever they want inside (which in HubSpot's case would be to add prometheus-backed p99 and median vttablet latencies)See the attached issue for the background, but I hope this can be a non-intrusive way to accomplish adding p99 latency metrics.
Adding tests & documentation is in progress
Related Issue(s)
Fixes #18597
Checklist
Deployment Notes