Skip to content

Fix: Improve VDiff internal query performance #18579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −6
Open

Fix: Improve VDiff internal query performance #18579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4b20d2
Add an index on `vdiff_log.vdiff_id`.
arthurschreiber Aug 26, 2025
d5fa9f2
Switch to `bigint` for `vdiff_log.id` and `vdiff_log.vdiff_id`.
arthurschreiber Aug 26, 2025
718221a
Switch `vdiff_tablet.vdiff_id` to `bigint`.
arthurschreiber Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions go/vt/sidecardb/schema/vdiff/vdiff_log.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@ limitations under the License.

CREATE TABLE IF NOT EXISTS vdiff_log
(
`id` int(11) NOT NULL AUTO_INCREMENT,
`vdiff_id` int(11) NOT NULL,
`created_at` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP,
`message` text NOT NULL,
PRIMARY KEY (`id`)
`id` bigint(20) NOT NULL AUTO_INCREMENT,
`vdiff_id` bigint(20) NOT NULL,
`created_at` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP,
`message` text NOT NULL,
PRIMARY KEY (`id`),
KEY `vdiff_id_idx` (`vdiff_id`)
) ENGINE = InnoDB CHARSET = utf8mb4
2 changes: 1 addition & 1 deletion go/vt/sidecardb/schema/vdiff/vdiff_table.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ limitations under the License.

CREATE TABLE IF NOT EXISTS vdiff_table
(
`vdiff_id` varchar(64) NOT NULL,
`vdiff_id` bigint(20) NOT NULL,
`table_name` varbinary(128) NOT NULL,
`state` varbinary(64) DEFAULT NULL,
`lastpk` varbinary(2000) DEFAULT NULL,
Expand Down
Loading