Refactor vtcombo flags - Part 4

[mounicasruthi]

Description

This PR is a part of an ongoing change to support the transition from underscores (_) to dashes (-) in flag naming conventions. This PR refactors some flags specific to vtcombo binary.

Flags Updated in This PR:

--relay-log-max-items
--relay-log-max-size
--restore-concurrency
--restore-from-backup
--restore-from-backup-ts
--retain-online-ddl-tables
--sanitize-log-messages
--schema-change-signal
--schema-dir
--serving-state-grace-period
--shard-sync-retry-delay
--shutdown-grace-period
--start-mysql
--stream-buffer-size
--stream-health-buffer-size
--table-gc-lifecycle
--tablet-filters
--throttle-tablet-types
--track-schema-versions
--twopc-abandon-age
--tx-throttler-config
--tx-throttler-healthcheck-cells
--unhealthy-threshold

Flag Count Before vs After:

	Flags with _	Flags with -
Before	193	1885
After	148	1932

# of migrated flags: 47

Related Issue(s)

#17880

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[dbussink]

There's a relevant test failure here?

        config_test.go:146: NewVReplicationConfig() got num errors = unknown vreplication config flag: relay_log_max_size, want 0

[codecov]

Codecov Report

❌ Patch coverage is 67.44186% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.48%. Comparing base (b079554) to head (ff62324).

Files with missing lines	Patch %	Lines
go/vt/utils/flags.go	25.00%	6 Missing ⚠️
go/cmd/vtcombo/cli/main.go	0.00%	2 Missing ⚠️
go/vt/vtgate/vtgate.go	0.00%	2 Missing ⚠️
.../vt/vttablet/tabletmanager/vreplication/vplayer.go	0.00%	2 Missing ⚠️
go/vt/discovery/healthcheck.go	50.00%	1 Missing ⚠️
go/vt/vttablet/tabletserver/gc/tablegc.go	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #18422      +/-   ##
==========================================
- Coverage   67.49%   67.48%   -0.01%     
==========================================
  Files        1607     1607              
  Lines      263518   263529      +11     
==========================================
- Hits       177849   177837      -12     
- Misses      85669    85692      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[systay]

should we mention this in the changelog so people know?