-
Notifications
You must be signed in to change notification settings - Fork 2.2k
vtorc
: update metrics in e2e test TestAPIEndpoints
#18406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timvaillancourt
wants to merge
7
commits into
vitessio:main
Choose a base branch
from
timvaillancourt:vtorc-update-e2e-test-metrics-TestAPIEndpoints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
vtorc
: update metrics in e2e test TestAPIEndpoints
#18406
timvaillancourt
wants to merge
7
commits into
vitessio:main
from
timvaillancourt:vtorc-update-e2e-test-metrics-TestAPIEndpoints
+44
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Vaillancourt <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18406 +/- ##
========================================
Coverage 67.50% 67.51%
========================================
Files 1603 1607 +4
Lines 262496 263343 +847
========================================
+ Hits 177198 177787 +589
- Misses 85298 85556 +258 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
deepthi
approved these changes
Jun 30, 2025
deepthi
reviewed
Jun 30, 2025
Signed-off-by: Tim Vaillancourt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Observability
Pull requests that touch tracing/metrics/monitoring
Component: VTorc
Vitess Orchestrator integration
Type: Internal Cleanup
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the metrics checked in the
TestAPIEndpoints
e2e test for VTOrcAlso, a metric I recently added in v22 was renamed from
DiscoverInstanceTimings
->DiscoveryInstanceTimings
for consistency. The later will be deleted in v24+Related Issue(s)
Checklist
Deployment Notes