Skip to content

Conversation

timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented Jun 29, 2025

Description

This PR updates the metrics checked in the TestAPIEndpoints e2e test for VTOrc

Also, a metric I recently added in v22 was renamed from DiscoverInstanceTimings -> DiscoveryInstanceTimings for consistency. The later will be deleted in v24+

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt timvaillancourt added Type: Internal Cleanup Component: VTorc Vitess Orchestrator integration labels Jun 29, 2025
Copy link
Contributor

vitess-bot bot commented Jun 29, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 29, 2025
@github-actions github-actions bot added this to the v23.0.0 milestone Jun 29, 2025
@timvaillancourt timvaillancourt removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jun 29, 2025
Signed-off-by: Tim Vaillancourt <[email protected]>
Copy link

codecov bot commented Jun 29, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.51%. Comparing base (aa68b96) to head (db69aae).
⚠️ Report is 72 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtorc/logic/vtorc.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #18406    +/-   ##
========================================
  Coverage   67.50%   67.51%            
========================================
  Files        1603     1607     +4     
  Lines      262496   263343   +847     
========================================
+ Hits       177198   177787   +589     
- Misses      85298    85556   +258     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt marked this pull request as ready for review June 30, 2025 17:29
@timvaillancourt timvaillancourt added the Component: Observability Pull requests that touch tracing/metrics/monitoring label Jun 30, 2025
Signed-off-by: Tim Vaillancourt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Observability Pull requests that touch tracing/metrics/monitoring Component: VTorc Vitess Orchestrator integration Type: Internal Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants