Adding an interface for v schema #17686
Open
+338
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s Operator Compatibility Matrix Removed specific Kubernetes version instructions from examples/operator/README.md. Added a link to the Vitess Operator Compatibility Matrix for up-to-date Kubernetes version information. This change centralizes Kubernetes version recommendations and ensures users are directed to the most current documentation. Related Issue: [vitessio#1022](vitessio/website#1022) Signed-off-by: Anshika Vashistha <[email protected]>
…s Operator Compatibility Matrix Signed-off-by: Anshika Vashistha <[email protected]>
Co-authored-by: Matt Lord <[email protected]> Signed-off-by: Anshika Vashistha <[email protected]>
Signed-off-by: Anshika Vashistha <[email protected]>
Signed-off-by: anshikavashistha <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
anshikavashistha
requested review from
ajm188,
deepthi,
rohit-nayak-ps and
mattlord
as code owners
anshikavashistha
commented
Feb 3, 2025
There was a problem hiding this comment.
- Implemented
gRPCVSchemaOperationsstruct - Added atomic operations with version checking
- Implemented retry logic for concurrent modifications
anshikavashistha
commented
Feb 3, 2025
There was a problem hiding this comment.
- Added basic client operation tests
- Added validation tests
- Added error condition tests
anshikavashistha
commented
Feb 3, 2025
There was a problem hiding this comment.
- Implemented
gRPCVSchemaOperationsstruct - Added atomic operations with version checking
- Implemented retry logic for concurrent modifications
anshikavashistha
commented
Feb 3, 2025
| AddTable(ctx context.Context, keyspace, tableName string, tableSpec interface{}) error | ||
|
|
||
| // RemoveTable atomically removes a table from the VSchema | ||
| RemoveTable(ctx context.Context, keyspace, tableName string) error |
There was a problem hiding this comment.
- Added new
VSchemaOperationsinterface for atomic VSchema modifications - Extended
VtctlClientinterface to include VSchema operations - Added methods for AddTable, RemoveTable, AddVindex, RemoveVindex
anshikavashistha
commented
Feb 3, 2025
| ts *memorytopo.Server | ||
| } | ||
|
|
||
| // Implement VtctlClient interface methods... |
There was a problem hiding this comment.
- Added comprehensive test suite for atomic operations
- Added concurrent modification tests
- Added version conflict tests
- Added integration tests with memory topo
anshikavashistha
commented
Feb 3, 2025
| func (s *VtctlServer) AddVSchemaTable(ctx context.Context, req *vtctlservicepb.AddVSchemaTableRequest) (*vtctlservicepb.AddVSchemaTableResponse, error) { | ||
| // Implement server-side handling of atomic VSchema modifications | ||
| return nil, nil // Placeholder return, actual implementation needed | ||
| } |
There was a problem hiding this comment.
- Added comprehensive test suite for atomic operations
- Added concurrent modification tests
- Added version conflict tests
- Added integration tests with memory topo
mattlord
reviewed
Feb 4, 2025
There was a problem hiding this comment.
No changes are needed in this file.
mattlord
reviewed
Feb 4, 2025
There was a problem hiding this comment.
vtctlclient is deprecated so no changes needed there. I'm also not sure what this is supposed to be used for.
There was a problem hiding this comment.
You can see how the ApplyVSchema command is implemented here on the vtctldclient side: https://github.com/vitessio/vitess/blob/main/go/cmd/vtctldclient/command/vschemas.go
And on the VtctldServer side: https://github.com/vitessio/vitess/blob/main/go/vt/vtctl/grpcvtctldserver/server.go
You can see a recent PR that added a couple of simple new commands here: #17442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Add an interface for modifying discrete parts of the VSchema via concrete actions: AddTable, AddVindex, RemoveTable, etc. #17663
Checklist
Deployment Notes