-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Planner support for VALUES-based BlockJoins #17641
Draft
frouioui
wants to merge
56
commits into
vitessio:main
Choose a base branch
from
planetscale:values-join-planner
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,899
−692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17641 +/- ##
==========================================
+ Coverage 67.50% 67.57% +0.06%
==========================================
Files 1595 1600 +5
Lines 259640 260262 +622
==========================================
+ Hits 175280 175864 +584
- Misses 84360 84398 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
57f12cf
to
ea41169
Compare
ea41169
to
0c70b4f
Compare
762b226
to
b824a25
Compare
5 tasks
e82817a
to
671b022
Compare
671b022
to
31fea9e
Compare
1607f03
to
24c359f
Compare
24c359f
to
deb7922
Compare
59154c7
to
be1c49b
Compare
be1c49b
to
950edc4
Compare
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
d0a3841
to
745153e
Compare
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
eb3831f
to
aa1b7f5
Compare
aa1b7f5
to
c4c9c39
Compare
c4c9c39
to
39bfa1b
Compare
Signed-off-by: Andres Taylor <[email protected]>
39bfa1b
to
492dd46
Compare
Signed-off-by: Andres Taylor <[email protected]>
66f8328
to
bbcd744
Compare
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
3781dc1
to
b0dbcec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Query Serving
release notes (needs details)
This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...)
Type: Feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds query planning support for the new BlockJoin execution strategy, as proposed in the RFC.
We’ve also streamlined the engine primitive, starting with a minimal implementation before introducing advanced features.
To ensure stability, the new join strategy is currently gated behind a feature flag and query hint—it will only be activated if either the feature flag is enabled or the query explicitly includes the
/*vt+ ALLOW_BLOCK_JOIN */
directive.At this stage, usage is restricted to inner joins involving exactly two standard tables. Further development and testing in the planner will be required to support additional query scenarios.
Related Issue(s)
Documentation
allow_block_join
comment directive to the docs website#1962