Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Address SwitchTraffic bugs around replication lag and cancel on error #17616

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
+276 −65

Derive sourceKs and targetKs from input tablets

2253a88
Select commit
Loading
Failed to load commit list.
Open

VReplication: Address SwitchTraffic bugs around replication lag and cancel on error #17616

Derive sourceKs and targetKs from input tablets
2253a88
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 24, 2025 in 0s

67.63% (-0.06%) compared to 99856a2

View this Pull Request on Codecov

67.63% (-0.06%) compared to 99856a2

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 52 lines in your changes missing coverage. Please review.

Project coverage is 67.63%. Comparing base (99856a2) to head (2253a88).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/traffic_switcher.go 25.00% 21 Missing ⚠️
go/vt/vtctl/workflow/server.go 42.85% 16 Missing ⚠️
go/vt/vtctl/workflow/workflows.go 81.81% 6 Missing ⚠️
go/vt/vtctl/workflow/stream_migrator.go 54.54% 5 Missing ⚠️
go/vt/vtctl/workflow/switcher.go 0.00% 2 Missing ⚠️
go/vt/vtctl/workflow/switcher_dry_run.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17616      +/-   ##
==========================================
- Coverage   67.69%   67.63%   -0.06%     
==========================================
  Files        1586     1586              
  Lines      255403   255666     +263     
==========================================
+ Hits       172883   172911      +28     
- Misses      82520    82755     +235

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov