Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up duplicate datetime parsing code #17582

Merged
merged 1 commit into from
Jan 21, 2025

Clean up duplicate datetime parsing code

06810e5
Select commit
Loading
Failed to load commit list.
Merged

Clean up duplicate datetime parsing code #17582

Clean up duplicate datetime parsing code
06810e5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 20, 2025 in 0s

67.70% (-0.01%) compared to 10ff5e3, passed because coverage increased by 0% when compared to adjusted base (67.70%)

View this Pull Request on Codecov

67.70% (-0.01%) compared to 10ff5e3, passed because coverage increased by 0% when compared to adjusted base (67.70%)

Details

Codecov Report

Attention: Patch coverage is 78.37838% with 8 lines in your changes missing coverage. Please review.

Project coverage is 67.70%. Comparing base (10ff5e3) to head (06810e5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vitessdriver/convert.go 78.37% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17582      +/-   ##
==========================================
- Coverage   67.70%   67.70%   -0.01%     
==========================================
  Files        1585     1585              
  Lines      254833   254827       -6     
==========================================
- Hits       172547   172539       -8     
- Misses      82286    82288       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.