-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix how we generate the query serving error documentation #17516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jan 13, 2025
frouioui
added
Type: Bug
Component: Query Serving
Backport to: release-21.0
Needs to be backport to release-21.0
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jan 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17516 +/- ##
==========================================
- Coverage 67.71% 67.70% -0.02%
==========================================
Files 1584 1584
Lines 254519 254524 +5
==========================================
- Hits 172338 172313 -25
- Misses 82181 82211 +30 ☔ View full report in Codecov by Sentry. |
GuptaManan100
approved these changes
Jan 14, 2025
systay
approved these changes
Jan 15, 2025
vitess-bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
added a commit
that referenced
this pull request
Jan 21, 2025
…ion (#17516) (#17536) Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Florent Poinsard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small change introduced to our error code led to the query serving error documentation generation to not work as expected: It was trying to parse the arguments (%s, %d, etc) in the strings and was printing things like
'%!s(MISSING)'
instead of'%s'
. The issue is visible in this PR, specifically this commit: vitessio/website@98b15a1
(#1905).We should backport this to 21.0 as the issue was first introduced there.
I have updated vitessio/website#1905 with the newly generated docs for each branch (from 19 to main).