-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vtadmin: enable sorting in all tables #17468
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: c-r-dev <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: c-r-dev <[email protected]>
Signed-off-by: c-r-dev <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17468 +/- ##
==========================================
- Coverage 67.69% 67.62% -0.08%
==========================================
Files 1585 1586 +1
Lines 254918 255629 +711
==========================================
+ Hits 172569 172862 +293
- Misses 82349 82767 +418 ☔ View full report in Codecov by Sentry. |
Signed-off-by: c-r-dev <[email protected]>
Hi @c-r-dev - I have some UI feedback if that's alright 😄
|
Signed-off-by: c-r-dev <[email protected]>
Thanks @notfelineit for helping to review and suggest changes. Made changed with 30007fe As part of commit -
Please help to let me know. New UI looks like below |
Description
vtadmin: enable table sorting, for the schemas table to sort by size / rows.
Related Issue(s)
Fixes #14153
Checklist
Deployment Notes
Creating this PR as draft mode , introduced new SortedDataTable (inline with DataTable + some logic. on columns being sortable).
Open for ideas on refactoring , and also would like to know if the UI changes have a std test pack to be run.
Tested these changes locally.