-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Views: VTGate changes for seamless integration #17439
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
6fe32dd
to
43c8519
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17439 +/- ##
=======================================
Coverage 67.70% 67.71%
=======================================
Files 1585 1585
Lines 254833 254902 +69
=======================================
+ Hits 172547 172615 +68
- Misses 82286 82287 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
… not required Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
43cc0f5
to
43718a4
Compare
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not need any new tests for these changes?
The follow up PR would need test regarding global routing for sharded and unsharded views. |
Description
This PR updates view support to seamlessly integrate with VTGate when the “enable-views” flag is default-on.
It unifies the logic for creating, altering, and dropping views.
Additional tests are unnecessary, as existing tests should continue to validate the unified logic.
Related Issue(s)
Checklist
Deployment Notes