minor tweaks

Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
vitessio · Jan 9, 2025 · e9b7d2d · e9b7d2d
1 parent 258d329
commit e9b7d2d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/go/vt/sqlparser/ast.go b/go/vt/sqlparser/ast.go
@@ -3579,11 +3579,14 @@ type Limit struct {
 // Values represents a VALUES clause.
 type Values []ValTuple
 
+// ValuesStatement represents a VALUES statement, as in VALUES ROW(1, 2), ROW(3, 4)
 type ValuesStatement struct {
+	// One but not both of these fields can be set.
 	Rows    Values
 	ListArg ListArg
-	Order   OrderBy
-	Limit   *Limit
+
+	Order OrderBy
+	Limit *Limit
 }
 
 // UpdateExprs represents a list of update expressions.

diff --git a/go/vt/sqlparser/parsed_query.go b/go/vt/sqlparser/parsed_query.go
@@ -59,8 +59,6 @@ func (pq *ParsedQuery) GenerateQuery(bindVariables map[string]*querypb.BindVaria
 	return buf.String(), nil
 }
 
-// values row(::val)
-// values row(), row(), row()
 // Append appends the generated query to the provided buffer.
 func (pq *ParsedQuery) Append(buf *strings.Builder, bindVariables map[string]*querypb.BindVariable, extras map[string]Encodable) error {
 	current := 0