add comment

Signed-off-by: Florent Poinsard <[email protected]>
vitessio · Jan 31, 2025 · a41541a · a41541a
1 parent 1d4855b
commit a41541a
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/go/vt/vtgate/executorcontext/vcursor_impl.go b/go/vt/vtgate/executorcontext/vcursor_impl.go
@@ -794,6 +794,7 @@ func (vc *VCursorImpl) ExecuteMultiShard(ctx context.Context, primitive engine.P
 	atomic.AddUint64(&vc.logStats.ShardQueries, uint64(noOfShards))
 	err := vc.markSavepoint(ctx, rollbackOnError && (noOfShards > 1), map[string]*querypb.BindVariable{})
 	if err != nil {
+		// this may be a bit too aggressive, maybe we just want to rollback if we receive a VT15001 error.
 		vc.setRollbackOnPartialExecIfRequired(true, rollbackOnError)
 		return nil, []error{err}
 	}