test: Add unit test for multiple lookup vindex create

Signed-off-by: Noble Mittal <[email protected]>
vitessio · Feb 3, 2025 · 447cf1b · 447cf1b
1 parent fcb540b
commit 447cf1b
Showing 1 changed file with 197 additions and 0 deletions.
diff --git a/go/vt/vtctl/workflow/materializer_test.go b/go/vt/vtctl/workflow/materializer_test.go
@@ -1157,6 +1157,203 @@ func TestCreateLookupVindexFull(t *testing.T) {
 	utils.MustMatch(t, wantvschema, vschema.Keyspace)
 }
 
+func TestCreateLookupVindexMultipleCreate(t *testing.T) {
+	ms := &vtctldatapb.MaterializeSettings{
+		Workflow:       "lookup",
+		SourceKeyspace: "sourceks",
+		TargetKeyspace: "targetks",
+	}
+	ctx, cancel := context.WithCancel(context.Background())
+	defer cancel()
+
+	env := newTestMaterializerEnv(t, ctx, ms, []string{"0"}, []string{"0"})
+	defer env.close()
+
+	specs := &vschemapb.Keyspace{
+		Vindexes: map[string]*vschemapb.Vindex{
+			"v1": {
+				Type: "lookup_unique",
+				Params: map[string]string{
+					"table": "targetks.lookup",
+					"from":  "c1",
+					"to":    "c2",
+				},
+				Owner: "t1",
+			},
+			"v2": {
+				Type: "lookup_unique",
+				Params: map[string]string{
+					"table": "targetks.lookup",
+					"from":  "c3",
+					"to":    "c4",
+				},
+				Owner: "t2",
+			},
+		},
+		Tables: map[string]*vschemapb.Table{
+			"t1": {
+				ColumnVindexes: []*vschemapb.ColumnVindex{{
+					Name:   "v1",
+					Column: "col2",
+				}},
+			},
+			"t2": {
+				ColumnVindexes: []*vschemapb.ColumnVindex{{
+					Name:   "v2",
+					Column: "col4",
+				}},
+			},
+		},
+	}
+	// Dummy sourceSchema
+	sourceSchema1 := "CREATE TABLE `t1` (\n" +
+		"  `col1` int(11) NOT NULL AUTO_INCREMENT,\n" +
+		"  `col2` int(11) DEFAULT NULL,\n" +
+		"  PRIMARY KEY (`id`)\n" +
+		") ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=latin1"
+
+	sourceSchema2 := "CREATE TABLE `t2` (\n" +
+		"  `col3` int(11) NOT NULL AUTO_INCREMENT,\n" +
+		"  `col4` int(11) DEFAULT NULL,\n" +
+		"  PRIMARY KEY (`id`)\n" +
+		") ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=latin1"
+
+	sourceVSchema := &vschemapb.Keyspace{
+		Sharded: true,
+		Vindexes: map[string]*vschemapb.Vindex{
+			"xxhash": {
+				Type: "xxhash",
+			},
+		},
+		Tables: map[string]*vschemapb.Table{
+			"t1": {
+				ColumnVindexes: []*vschemapb.ColumnVindex{{
+					Name:   "xxhash",
+					Column: "col1",
+				}},
+			},
+			"t2": {},
+		},
+	}
+	env.tmc.schema[ms.SourceKeyspace+".t1"] = &tabletmanagerdatapb.SchemaDefinition{
+		TableDefinitions: []*tabletmanagerdatapb.TableDefinition{{
+			Fields: []*querypb.Field{{
+				Name: "col1",
+				Type: querypb.Type_INT64,
+			}, {
+				Name: "col2",
+				Type: querypb.Type_INT64,
+			}},
+			Schema: sourceSchema1,
+		}},
+	}
+	env.tmc.schema[ms.SourceKeyspace+".t2"] = &tabletmanagerdatapb.SchemaDefinition{
+		TableDefinitions: []*tabletmanagerdatapb.TableDefinition{{
+			Fields: []*querypb.Field{{
+				Name: "col3",
+				Type: querypb.Type_INT64,
+			}, {
+				Name: "col4",
+				Type: querypb.Type_INT64,
+			}},
+			Schema: sourceSchema2,
+		}},
+	}
+	if err := env.topoServ.SaveVSchema(ctx, &topo.KeyspaceVSchemaInfo{
+		Name:     ms.TargetKeyspace,
+		Keyspace: &vschemapb.Keyspace{},
+	}); err != nil {
+		t.Fatal(err)
+	}
+	if err := env.topoServ.SaveVSchema(ctx, &topo.KeyspaceVSchemaInfo{
+		Name:     ms.SourceKeyspace,
+		Keyspace: sourceVSchema,
+	}); err != nil {
+		t.Fatal(err)
+	}
+
+	env.tmc.expectVRQuery(100, mzCheckJournal, &sqltypes.Result{})
+	env.tmc.expectFetchAsAllPrivsQuery(200, "select 1 from `lookup` limit 1", &sqltypes.Result{})
+
+	// Expect this query twice for 2 vindexes.
+	env.tmc.expectVRQuery(200, "/CREATE TABLE `lookup`", &sqltypes.Result{})
+	env.tmc.expectVRQuery(200, "/CREATE TABLE `lookup`", &sqltypes.Result{})
+
+	env.tmc.expectVRQuery(200, mzGetCopyState, &sqltypes.Result{})
+	env.tmc.expectVRQuery(200, mzGetLatestCopyState, &sqltypes.Result{})
+	env.tmc.expectVRQuery(200, insertPrefix, &sqltypes.Result{})
+	env.tmc.expectVRQuery(200, "update _vt.vreplication set state='Running' where db_name='vt_targetks' and workflow='lookup'", &sqltypes.Result{})
+
+	req := &vtctldatapb.LookupVindexCreateRequest{
+		Workflow:    ms.Workflow,
+		Keyspace:    ms.SourceKeyspace,
+		Cells:       []string{"cell"},
+		TabletTypes: []topodatapb.TabletType{topodatapb.TabletType_PRIMARY},
+		Vindex:      specs,
+	}
+
+	_, err := env.ws.LookupVindexCreate(ctx, req)
+	require.NoError(t, err)
+
+	wantvschema := &vschemapb.Keyspace{
+		Sharded: true,
+		Vindexes: map[string]*vschemapb.Vindex{
+			"xxhash": {
+				Type: "xxhash",
+			},
+			"v1": {
+				Type: "lookup_unique",
+				Params: map[string]string{
+					"table":      "targetks.lookup",
+					"from":       "c1",
+					"to":         "c2",
+					"write_only": "true",
+				},
+				Owner: "t1",
+			},
+			"v2": {
+				Type: "lookup_unique",
+				Params: map[string]string{
+					"table":      "targetks.lookup",
+					"from":       "c3",
+					"to":         "c4",
+					"write_only": "true",
+				},
+				Owner: "t2",
+			},
+		},
+		Tables: map[string]*vschemapb.Table{
+			"t1": {
+				ColumnVindexes: []*vschemapb.ColumnVindex{{
+					Name:   "xxhash",
+					Column: "col1",
+				}, {
+					Name:   "v1",
+					Column: "col2",
+				}},
+			},
+			"t2": {
+				ColumnVindexes: []*vschemapb.ColumnVindex{{
+					Name:   "v2",
+					Column: "col4",
+				}},
+			},
+		},
+	}
+	vschema, err := env.topoServ.GetVSchema(ctx, ms.SourceKeyspace)
+	require.NoError(t, err)
+	utils.MustMatch(t, wantvschema, vschema.Keyspace)
+
+	wantvschema = &vschemapb.Keyspace{
+		Tables: map[string]*vschemapb.Table{
+			"lookup": {},
+		},
+	}
+	vschema, err = env.topoServ.GetVSchema(ctx, ms.TargetKeyspace)
+	require.NoError(t, err)
+	utils.MustMatch(t, wantvschema, vschema.Keyspace)
+}
+
 func TestCreateLookupVindexCreateDDL(t *testing.T) {
 	ms := &vtctldatapb.MaterializeSettings{
 		SourceKeyspace: "sourceks",