Fixes #14414: resilient_server metrics name/prefix

logic is inverted, leading to no metrics being recorded Signed-off-by: Jacques Grove <[email protected]>
vitessio · Nov 1, 2023 · 374ca8b · 374ca8b
1 parent 54eedf8
commit 374ca8b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/go/vt/srvtopo/resilient_server.go b/go/vt/srvtopo/resilient_server.go
@@ -85,7 +85,7 @@ func NewResilientServer(ctx context.Context, base *topo.Server, counterPrefix st
 	}
 
 	var metric string
-	if counterPrefix == "" {
+	if counterPrefix != "" {
 		metric = counterPrefix + "Counts"
 	} else {
 		metric = ""

diff --git a/go/vt/srvtopo/resilient_server_test.go b/go/vt/srvtopo/resilient_server_test.go
@@ -811,7 +811,7 @@ func TestSrvKeyspaceListener(t *testing.T) {
 		srvTopoCacheRefresh = 1 * time.Second
 	}()
 
-	rs := NewResilientServer(ctx, ts, "TestGetSrvKeyspaceWatcher")
+	rs := NewResilientServer(ctx, ts, "TestGetSrvKeyspaceListener")
 
 	cancelCtx, cancelFunc := context.WithCancel(context.Background())
 	var callbackCount atomic.Int32