feat(react-compiler): add React Compiler variants to create-vite #20702
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poteto
force-pushed
the
vite-react-compiler
branch
from
446f867 to
78f0bca
Compare
poteto
changed the title
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+134
to
+136
| customCommand: | ||
| 'npm exec degit vitejs/vite-plugin-react/packages/plugin-react/examples/compiler-ts TARGET_DIR', | ||
| }, |
There was a problem hiding this comment.
The placeholder TARGET_DIR in the customCommand may not be automatically replaced at runtime. Please verify that the create-vite CLI properly handles this substitution pattern. If not, users might end up with a literal directory named "TARGET_DIR" instead of their intended project directory. Consider checking how variable substitution works in custom commands or updating to use the correct placeholder format supported by the system.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This PR builds upon vitejs/vite-plugin-react#799 and adds 2 new variants to create-vite: compiler, and compiler-ts. This allows new Vite apps to start with React Compiler out of the box.
poteto
force-pushed
the
vite-react-compiler
branch
from
78f0bca to
b29d9ab
Compare
poteto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon vitejs/vite-plugin-react#799 and adds 2 new variants to create-vite: compiler, and compiler-ts.
This allows new Vite apps to start with React Compiler out of the box.